Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font and typography update #67

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Font and typography update #67

merged 6 commits into from
Dec 12, 2023

Conversation

kkosiorowska
Copy link
Contributor

This PR updates typography components:

  • adds Segment font
  • sets the correct styles based on the designs
  • creates a directory for the shared components

@kkosiorowska kkosiorowska added the 🎨 dApp dApp label Dec 7, 2023
@kkosiorowska kkosiorowska added this to the MVP milestone Dec 7, 2023
@kkosiorowska kkosiorowska self-assigned this Dec 7, 2023
@kkosiorowska kkosiorowska mentioned this pull request Dec 7, 2023
Closed
r-czajkowski
r-czajkowski requested changes Dec 12, 2023
View reviewed changes
dapp/src/components/GlobalStyles/index.tsx Outdated Show resolved Hide resolved
dapp/src/components/shared/Typography/index.tsx Outdated Show resolved Hide resolved
dapp/src/components/shared/Typography/index.tsx Outdated Show resolved Hide resolved
dapp/src/components/shared/Typography/index.tsx Outdated Show resolved Hide resolved
dapp/src/theme/utils/fonts.ts Outdated Show resolved Hide resolved
r-czajkowski
r-czajkowski requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment. Overall LGTM!

dapp/src/components/shared/Typography/index.tsx Outdated Show resolved Hide resolved
dapp/src/theme/Heading.ts
@@ -0,0 +1,32 @@
import { ComponentSingleStyleConfig } from "@chakra-ui/react"

const Heading: ComponentSingleStyleConfig = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

r-czajkowski
r-czajkowski approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@r-czajkowski r-czajkowski merged commit f8a2b11 into main Dec 12, 2023
9 checks passed
@r-czajkowski r-czajkowski deleted the update-fonts branch December 12, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-czajkowski r-czajkowski r-czajkowski approved these changes

Assignees

@kkosiorowska kkosiorowska

Labels
🎨 dApp dApp
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@kkosiorowska @r-czajkowski